Re: [PATCH] prune: --expire=time

From: Junio C Hamano <junkio@cox.net>
Date: Jan 22, 2007, 07:12 UTC
Message-ID: <7vd557v8l6.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0701212137370.14248@woody.osdl.org>

Linus Torvalds <torvalds@osdl.org> writes:

Show 9 quoted lines

> On Sun, 21 Jan 2007, Junio C Hamano wrote:
>> 
>> I've been annoyed by those scary messages fsck-objects enough
>> and was wondering if we could make it less scary.  Especially
>> annoying is that the message about missing blobs and trees that
>> are only referred to by dangling commits.
> ...
> Add my sign-off on the patch as appropriate. I do think it's mergeable, 
> but I'd _really_ like somebody else to double-check me here.

I think this is very sensible. Even without all the added comments, the refactoring makes the code much more readable.

-- >8 --
From: Linus Torvalds <torvalds@osdl.org>
Date: Sun, 21 Jan 2007 22:26:41 -0800 (PST)
Subject: [PATCH] fsck-objects: refactor checking for connectivity

This separates the connectivity check into separate codepaths, one for reachable objects and the other for unreachable ones, while adding a lot of comments to explain what is going on.

When checking an unreachable object, unlike a reachable one, we do not have to complain if it does not exist (we used to complain about a missing blob even when the only thing that references it is a tree that is dangling). Also we do not have to check and complain about objects that are referenced by an unreachable object.

This makes the messages from fsck-objects a lot less noisy and more useful.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
---
 <<your patch here>>