Re: [PATCH] prune: --expire=time

From: Matthias Lederhofer <matled@gmx.net>
Date: Jan 21, 2007, 10:37 UTC
Message-ID: <20070121103724.GA23256@moooo.ath.cx>
In-Reply-To: <7vlkjw50nl.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:

> I am considering to commit the attached instead.

Looks fine. Just one question: You said normally unsigned long would be used for time_t but time_t itself seems to be signed. Using unsigned long instead of int for prune_grace_period (which is used as time_t here) results in 'warning: comparison between signed and unsigned'. Perhaps you want to change it here anyway to be consistent with the rest of the code (approxidate returns unsigned long too).

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.