Re: [PATCH 1/4] Add testcase for ammending and fixing author in git commit.

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 2, 2007, 20:07 UTC
Message-ID: <7vy7dg1kdg.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1194017589-4669-1-git-send-email-krh@redhat.com>

Kristian Høgsberg <krh@redhat.com> writes:

Show 24 quoted lines

> Signed-off-by: Kristian Høgsberg <krh@redhat.com>
> ---
>  t/t7501-commit.sh |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/t/t7501-commit.sh b/t/t7501-commit.sh
> index b151b51..3f2112a 100644
> --- a/t/t7501-commit.sh
> +++ b/t/t7501-commit.sh
> @@ -163,4 +163,14 @@ test_expect_success 'partial commit that involves removal (3)' '
>  
>  '
>  
> +author="The Real Author <someguy@his.email.org>"
> +test_expect_success 'amend commit to fix author' '
> +
> +	git reset --hard
> +	git cat-file -p HEAD | sed -e "s/author.*>/author $author/" > expected &&
> +	git commit --amend --author="$author" &&
> +	git cat-file -p HEAD > current &&
> +	diff expected current
> +	
> +'
>  test_done

This can't be right. How are you ignoring the differences in committer dates?

By the way, I _think_ git-commit.sh allows fixing author name/email without molesting the author timestamp (i.e. takes it from the amended commit). That should probably be checked with the test as well.