Re: [PATCH 1/4] Add testcase for ammending and fixing author in git commit.

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 2, 2007, 22:33 UTC
Message-ID: <7vk5p0z39l.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1194038030.25288.20.camel@hinata.boston.redhat.com>

Kristian Høgsberg <krh@redhat.com> writes:

Show 8 quoted lines

>> This can't be right.  How are you ignoring the differences in
>> committer dates?
>
> t/test-lib.sh fixes GIT_COMMITTER_DATE so all commits have the date
>
> committer C O Mitter <committer@example.com> 1112911993 -0700
>
> unless you use test_tick.

Heh, that was actually what I was getting at. By not doing test_tick, you are not making sure that the commit gets the timestamp of the time --amend is run.

Show 8 quoted lines

>> By the way, I _think_ git-commit.sh allows fixing author name/email
>> without molesting the author timestamp (i.e. takes it from the
>> amended commit).  That should probably be checked with the test
>> as well.
>
> You're right, I need to pick GIT_AUTHOR_DATE from the ammended commit.
> Ok, I'll need to rewrite determine_author_info() a little bit.  I might
> get an update patch out this weekend.