Re: [PATCH 2/4] Remove unecessary hard-coding of EDITOR=':' VISUAL=':' in some test suites.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 2, 2007, 20:09 UTC
- Message-ID
- <7vtzo41ka3.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <1194017589-4669-2-git-send-email-krh@redhat.com>
Kristian Høgsberg <krh@redhat.com> writes:
Show 5 quoted lines
> Signed-off-by: Kristian Høgsberg <krh@redhat.com> > --- > t/t3501-revert-cherry-pick.sh | 4 ++-- > t/t3901-i18n-patch.sh | 8 ++++---- > 2 files changed, 6 insertions(+), 6 deletions(-)
This is a good patch, but a real commit message that says why they are unnecessary is lacking. Something like...
Sourcing of ./test-lib.sh at the very beginning of test scripts
already define and export them.