git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git diff too slow for a file

From
Junio C Hamano <gitster@pobox.com>
Date
May 4, 2010, 22:56 UTC
Message-ID
<7vy6fzl1hl.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4BE080AF.2030604@lsrfire.ath.cx>
René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
Show 6 quoted lines
> But when I take a closer look at the surrounding code, I can't help but
> ask if the flags really have be passed in such a complicated way.
>
> How about the following, which makes xdi_diff*() take a simple flag
> parameter instead, moving the code to handle xpparam_t into
> xdiff-interface.c, which seems to be the proper place for it?

This looks very sensible. Your patch doesn't touch xdiff/ proper but only the thin interface layer, so we don't have to worry about deviating from the upstream even further.

Previous: René ScharfeNext: SungHyun Nam
Message 11 of 12 in “git diff too slow for a file”
  1. SungHyun NamMar 29, 2010
  2. René ScharfeApr 17, 2010
  3. Junio C HamanoApr 17, 2010
  4. René ScharfeApr 18, 2010
  5. Junio C HamanoApr 20, 2010
  6. René ScharfeApr 20, 2010
  7. Junio C HamanoApr 21, 2010
  8. René ScharfeMay 2, 2010
  9. Junio C HamanoMay 2, 2010
  10. René ScharfeMay 4, 2010
  11. Junio C HamanoMay 4, 2010
  12. SungHyun NamApr 19, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.