Re: git diff too slow for a file

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 21, 2010, 02:49 UTC
Message-ID: <7vzl0xcyf8.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4BCE1983.4020009@lsrfire.ath.cx>

René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:

Show 11 quoted lines

> Turning XDF_NEED_MINIMAL off by default looks like the sane thing to do
> in order to help the fringe cases without hurting the normal ones.
>
> A --slow/--minimal/--try-harder option for git diff could come in handy
> for longer patches, though.  GNU diff has it, too (-d/--minimal).
>
>> I expect that there will also be some differences in the blame output.
>
> I haven't looked at the impact on blame, but additionally patch IDs are
> going to change (for those patches where XDF_NEED_MINIMAL makes a
> difference).  Are they stored somewhere?  Do we need to worry about them?

Patch-IDs are purely transient inside core-git as far as I know, but I wouldn't surprised if people keep database of patch-IDs and corresponding commits to somehow speed up change look-ups.

Theoretically, conflict IDs used to index the rerere database would also be affected, but I don't think it is such a huge issue.