From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 04 May 2010 22:56:54 GMT
Subject: Re: git diff too slow for a file
Message-ID: <7vy6fzl1hl.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4BE080AF.2030604@lsrfire.ath.cx>

René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:

> But when I take a closer look at the surrounding code, I can't help but
> ask if the flags really have be passed in such a complicated way.
>
> How about the following, which makes xdi_diff*() take a simple flag
> parameter instead, moving the code to handle xpparam_t into
> xdiff-interface.c, which seems to be the proper place for it?

This looks very sensible.  Your patch doesn't touch xdiff/ proper but only
the thin interface layer, so we don't have to worry about deviating from
the upstream even further.