git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC v2] Do not strip empty lines / trailing spaces from a commit message template

From
Junio C Hamano <gitster@pobox.com>
Date
May 8, 2011, 18:14 UTC
Message-ID
<7vy62hrrf3.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4DC68C88.7030604@gmail.com>
Sebastian Schuberth <sschuberth@gmail.com> writes:
Show 14 quoted lines
> On 08.05.2011 12:31, Boris Faure wrote:
>
>> Templates should be just that: A form that the user fills out, and forms
>> have blanks. If people are attached to not having extra whitespace in the
>> editor, they can simply clean up their templates.
>>
>> Added test with editor adding even more whitespace.
>>
>> Signed-off-by: Boris Faure<billiob@gmail.com>
>> Based-on-patch-by:Sebastian Schuberth<sschuberth@gmail.com>
>
> Thanks for rebasing the patch and adding the test! I've run the whole
> test suite on Linux, and all tests pass for me (including the added
> one).

Thanks, both. The updated log message explains _why_ this change is a good thing very well.

I'd avoid "echo -e" which is not portable, though.
Previous: Sebastian SchuberthNext: Boris Faure
Message 10 of 11 in “commit: do not cleanup template”
  1. 1/2 commit: do not cleanup templateBoris Faure, May 7, 2011
  2. 2/2 commit: do not add a newline after a templateBoris Faure, May 7, 2011
  3. Junio C HamanoMay 7, 2011
  4. Boris 'billiob' FaureMay 7, 2011
  5. Junio C HamanoMay 7, 2011
  6. Sebastian SchuberthMay 8, 2011
  7. Sebastian SchuberthMay 8, 2011
  8. Do not strip empty lines / trailing spaces from a commit message templateBoris Faure, May 8, 2011
  9. Sebastian SchuberthMay 8, 2011
  10. Junio C HamanoMay 8, 2011
  11. Do not strip empty lines / trailing spaces from a commit message templateBoris Faure, May 8, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.