git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] commit: do not cleanup template

From
Sebastian Schuberth <sschuberth@gmail.com>
Date
May 8, 2011, 08:47 UTC
Message-ID
<4DC65888.7090309@gmail.com>
In-Reply-To
<7vwri2uv4m.fsf@alter.siamese.dyndns.org>
On 07.05.2011 22:13, Junio C Hamano wrote:
Show 6 quoted lines
> These two commits change the longstanding behaviour. It is hard to tell if
> the existing behaviour is something people who use commit log message
> templates have relied on (in which case your patch will be a regression to
> them) or they all shared the sense of annoyance and have been wishing to
> be improved (in which case nobody will be inconvenienced with your patch).
> They need to be explained a bit better why these changes are needed.

I forgot this in my first mail: Being one of the poeple that in general shares Boris' sense of annoyance, I'm voting in favor of his patch [1/2] (or mine, if it is any better), but not [2/2].

For any poeple that might be inconvenienced by the patch there is a trivial one-time fix: Strip whitespaces from their template. Because of this, I believe it is OK to change the long-standing behavior in this case.

-- 
Sebastian Schuberth
Previous: Sebastian SchuberthNext: Boris Faure
Message 7 of 11 in “commit: do not cleanup template”
  1. 1/2 commit: do not cleanup templateBoris Faure, May 7, 2011
  2. 2/2 commit: do not add a newline after a templateBoris Faure, May 7, 2011
  3. Junio C HamanoMay 7, 2011
  4. Boris 'billiob' FaureMay 7, 2011
  5. Junio C HamanoMay 7, 2011
  6. Sebastian SchuberthMay 8, 2011
  7. Sebastian SchuberthMay 8, 2011
  8. Do not strip empty lines / trailing spaces from a commit message templateBoris Faure, May 8, 2011
  9. Sebastian SchuberthMay 8, 2011
  10. Junio C HamanoMay 8, 2011
  11. Do not strip empty lines / trailing spaces from a commit message templateBoris Faure, May 8, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.