From: Junio C Hamano Date: Sun, 08 May 2011 18:14:08 GMT Subject: Re: [PATCH/RFC v2] Do not strip empty lines / trailing spaces from a commit message template Message-ID: <7vy62hrrf3.fsf@alter.siamese.dyndns.org> In-Reply-To: <4DC68C88.7030604@gmail.com> Sebastian Schuberth writes: > On 08.05.2011 12:31, Boris Faure wrote: > >> Templates should be just that: A form that the user fills out, and forms >> have blanks. If people are attached to not having extra whitespace in the >> editor, they can simply clean up their templates. >> >> Added test with editor adding even more whitespace. >> >> Signed-off-by: Boris Faure >> Based-on-patch-by:Sebastian Schuberth > > Thanks for rebasing the patch and adding the test! I've run the whole > test suite on Linux, and all tests pass for me (including the added > one). Thanks, both. The updated log message explains _why_ this change is a good thing very well. I'd avoid "echo -e" which is not portable, though.