git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv4 3/4] Support ref namespaces for remote repositories via upload-pack and receive-pack

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 3, 2011, 16:33 UTC
Message-ID
<7vy61ian8n.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20110603000612.GB30975@cloud>
josh@joshtriplett.org writes:
> Fair enough.  We'd thought of NULL as a fairly logical representation
> for a null ref sent as a dummy ref just to send capabilities,...

I am not objecting to that part. NULL may be a logical thing to throw at when the interface is to take only strings that begin with refs/... and you have to occasionally send something different.

But that is a line of thought that is only valid while there is only one "something different" (i.e. "capabilities^{}") and the current code happens to have only one such different thing to send, but the approach closes the door to allow us sending things other than that single exception in the future without redoing your patch. That was what I found objectionable.

Previous: josh@joshtriplett.orgNext: Jamey Sharp
Message 15 of 20 in “[PATCHv4 1/4] Refactor for_each_ref variants to use for_each_ref_in and avoid magic numbers”
  1. Jamey SharpJun 1, 2011
  2. 2/4 Add infrastructure for ref namespacesJamey Sharp, Jun 1, 2011
  3. Junio C HamanoJun 2, 2011
  4. Josh TriplettJun 2, 2011
  5. Junio C HamanoJun 3, 2011
  6. Josh TriplettJun 3, 2011
  7. Jakub NarebskiJun 3, 2011
  8. Josh TriplettJun 3, 2011
  9. Jakub NarebskiJun 8, 2011
  10. Josh TriplettJun 9, 2011
  11. Jakub NarebskiJun 9, 2011
  12. 3/4 Support ref namespaces for remote repositories via upload-pack and receive-packJamey Sharp, Jun 1, 2011
  13. Junio C HamanoJun 2, 2011
  14. josh@joshtriplett.orgJun 3, 2011
  15. Junio C HamanoJun 3, 2011
  16. 4/4 Add documentation for ref namespacesJamey Sharp, Jun 1, 2011
  17. Junio C HamanoJun 2, 2011
  18. Josh TriplettJun 2, 2011
  19. Junio C HamanoJun 2, 2011
  20. Jakub NarebskiJun 3, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.