Re: [PATCH/RFC jn/ident-from-etc-mailname] ident: do not retrieve default ident when unnecessary
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 6, 2011, 18:19 UTC
- Message-ID
- <7vy5wyyod1.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20111006171719.GB6946@elie>
Jonathan Nieder <jrnieder@gmail.com> writes:
> Avoid a getpwuid() call (which contacts the network if the password > database is not local), read of /etc/mailname, gethostname() call, and > reverse DNS lookup if the user has already chosen a name and email > through configuration, the environment, or the command line.
Oh boy that is a hard to parse paragraph that took me three reads.
In any case, both the motivation of the patch and the change itself make sense to me. Thanks.