Re: [PATCH/RFC jn/ident-from-etc-mailname] ident: do not retrieve default ident when unnecessary

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Oct 6, 2011, 18:48 UTC
Message-ID: <20111006184823.GB16942@elie>
In-Reply-To: <7vy5wyyod1.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

> Jonathan Nieder <jrnieder@gmail.com> writes:

Show 6 quoted lines

>> Avoid a getpwuid() call (which contacts the network if the password
>> database is not local), read of /etc/mailname, gethostname() call, and
>> reverse DNS lookup if the user has already chosen a name and email
>> through configuration, the environment, or the command line.
>
> Oh boy that is a hard to parse paragraph that took me three reads.

Here's a possible replacement:

 Avoid looking up the current user's password database entry (which
 might be on another machine) and the current machine's domain name for
 outgoing mail (which can involve a reverse DNS lookup) when the
 environment, configuration, or command line specifies a name and email
 that would override them.

Or it might make sense to drop that paragraph altogether, since the subject line already says as much.

Thanks for looking it over.

Sleepily, Jonathan