Re: [PATCH v2] ident: check /etc/mailname if email is unknown

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Oct 3, 2011, 07:09 UTC
Message-ID: <4E895FBD.8020904@viscovery.net>
In-Reply-To: <20111003061633.GB17289@elie>

Am 10/3/2011 8:16, schrieb Jonathan Nieder:

Show 9 quoted lines

> +static int add_mailname_host(char *buf, size_t len)
> +{
> +	FILE *mailname;
> +
> +	mailname = fopen("/etc/mailname", "r");
> +	if (!mailname) {
> +		if (errno != ENOENT)
> +			warning("cannot open /etc/mailname: %s",
> +				strerror(errno));

This warns on EACCES. Is that OK? (Just asking, I have no opinion.)

-- Hannes