Re: [PATCH 00/22] Refactor to accept NUL in commit messages

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 24, 2011, 04:40 UTC
Message-ID: <7vy5wb3sto.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7v39ej5uqb.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 10 quoted lines

> Jeff King <peff@peff.net> writes:
>
>> But as Duy mentions, we have an encoding header. Shouldn't we treat it
>> like binary goo until we do reencode_log_message, and _then_ we can
>> break it into lines?
>
> That's sensible. If we go that route, I think the "one allocation of
> separate struct commit_buffer pointed from a pointer field in struct
> commit to replace the current member 'buffer'" is a reasonable thing
> to do.

Having given that "sensible" comment, I am not convinced if this is worth it. We are talking about what is left in the ephemeral COMMIT_EDITMSG by the chosen editor, but are there really editors that can _only_ write in UTF-16 and not in UTF-8, and is it worth bending backwards to add support such an editor?