Re: [PATCH 00/22] Refactor to accept NUL in commit messages
- From
Jeff King <peff@peff.net>
- Date
- Oct 23, 2011, 16:07 UTC
- Message-ID
- <20111023160744.GA22444@sigill.intra.peff.net>
- In-Reply-To
- <7vehy459bg.fsf@alter.siamese.dyndns.org>
On Sun, Oct 23, 2011 at 02:46:59AM -0700, Junio C Hamano wrote:
Show 11 quoted lines
> > But when it comes to "Git" Porcelains (e.g. the log family of commands), > > we do assume people do not store random binary byte sequences in commits, > > and we do take advantage of that assumption by splitting each "line" at > > LF, indenting them with 4 spaces, etc. In other words, a commit log in the > > Git context _is_ pretty much text and not arbitrary byte sequence. > > Think what would cutting at a byte whose value is 012 and adding four > bytes whose values are 040 to each of "lines" that formed with such > cutting do to UTF-16 goo, even if it does not contain any NUL byte. As far > as Git Porcelains are concerned, it is no different from random binary > byte sequences.
But as Duy mentions, we have an encoding header. Shouldn't we treat it like binary goo until we do reencode_log_message, and _then_ we can break it into lines?
-Peff