git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] index-pack: restructure pack processing into three main functions

From
Junio C Hamano <gitster@pobox.com>
Date
May 8, 2012, 00:19 UTC
Message-ID
<7vy5p31q3e.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1336307516-1809-2-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
Show 10 quoted lines
> The second pass in parse_pack_objects() are split into
> resolve_deltas(). The final phase, fixing thin pack or just seal the
> pack, is now in conclude_pack() function. Main pack processing is now a
> sequence of these functions:
>
>  - parse_pack_objects() reads through the input pack
>  - resolve_deltas()     makes sure all deltas can be resolved
>  - conclude_pack()      seals the output pack
>  - write_idx_file()     writes companion index file
>  - final()              moves the pack/index to proper place

The resulting code looks much more streamlined, instead of just splitting out the second phase alone.

Very nice.  Thanks.
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 11 of 13 in “Multithread index-pack”
  1. 0/3 Multithread index-packNguyễn Thái Ngọc Duy, Apr 11, 2012
  2. 1/3 compat/win32/pthread.h: Add an pthread_key_delete() implementationNguyễn Thái Ngọc Duy, Apr 11, 2012
  3. 2/3 index-pack: split second pass obj handling into own functionNguyễn Thái Ngọc Duy, Apr 11, 2012
  4. 3/3 index-pack: support multithreaded delta resolvingNguyễn Thái Ngọc Duy, Apr 11, 2012
  5. Junio C HamanoMay 3, 2012
  6. Junio C HamanoMay 4, 2012
  7. Nguyen Thai Ngoc DuyMay 4, 2012
  8. Junio C HamanoMay 4, 2012
  9. 1/4 compat/win32/pthread.h: Add an pthread_key_delete() implementationNguyễn Thái Ngọc Duy, May 6, 2012
  10. 2/4 index-pack: restructure pack processing into three main functionsNguyễn Thái Ngọc Duy, May 6, 2012
  11. Junio C HamanoMay 8, 2012
  12. 3/4 index-pack: support multithreaded delta resolvingNguyễn Thái Ngọc Duy, May 6, 2012
  13. 4/4 index-pack: disable threading if NO_PREAD is definedNguyễn Thái Ngọc Duy, May 6, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.