From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 08 May 2012 00:19:49 GMT
Subject: Re: [PATCH 2/4] index-pack: restructure pack processing into three main functions
Message-ID: <7vy5p31q3e.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1336307516-1809-2-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> The second pass in parse_pack_objects() are split into
> resolve_deltas(). The final phase, fixing thin pack or just seal the
> pack, is now in conclude_pack() function. Main pack processing is now a
> sequence of these functions:
>
>  - parse_pack_objects() reads through the input pack
>  - resolve_deltas()     makes sure all deltas can be resolved
>  - conclude_pack()      seals the output pack
>  - write_idx_file()     writes companion index file
>  - final()              moves the pack/index to proper place

The resulting code looks much more streamlined, instead of just splitting
out the second phase alone.

Very nice.  Thanks.