Re: [PATCH 2/2] git-filter-branch.sh: don't use --default when calling rev-list
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 31, 2008, 09:27 UTC
- Message-ID
- <7vwspqcple.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <47A19211.5090409@op5.se>
Andreas Ericsson <ae@op5.se> writes:
> Well, if there's no filter specified it has nothing to do, so erroring out > in the no-arguments-at-all case would be sensible.
Actually, not erroring out but just returning doing nothing (if there truly isn't anything to do -- iow, the filtering operation turns out to be identity function) would be more sensible.
No filter does not necessarily mean identity, by the way. Think "grafts" ;-).