Re: [PATCH 2/2] git-filter-branch.sh: don't use --default when calling rev-list

From: Brandon Casey <casey@nrlssc.navy.mil>
Date: Jan 31, 2008, 01:35 UTC
Message-ID: <47A125D9.2070105@nrlssc.navy.mil>
In-Reply-To: <alpine.LSU.1.00.0801310048350.23907@racer.site>

Johannes Schindelin wrote:

Show 10 quoted lines

> Hi,
> 
> On Wed, 30 Jan 2008, Brandon Casey wrote:
> 
>> This command requires a revision to be specified on the command line, so 
>> remove '--default HEAD' from the arguments to git rev-list. They are 
>> unnecessary.
> 
> But I thought that you wanted "git filter-branch --msg-filter=rot13" to 
> work on HEAD by default?

I do. But isn't that inconsistent with "git filter-branch" does _not_ work on HEAD by default and instead prints out usage information?

If I do:

	git filter-branch -d /tmp/git_temp

and it is successful, I think I would also expect this to succeed:

	git filter-branch

So, I think the "operates on HEAD" by default is consistent with what other git tools do, but I think it is not consistent for filter-branch to sometimes operate on HEAD by default and sometimes error with usage information.

Disclaimer: I have only used filter-branch for two tasks.

-brandon