Re: [PATCH v4 10/13] branch: add --column

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 3, 2012, 23:11 UTC
Message-ID: <7vwr83ldfz.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1328276078-27955-11-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

Show 9 quoted lines

> @@ -474,7 +482,7 @@ static void print_ref_item(struct ref_item *item, int maxwidth, int verbose,
>  	else if (verbose)
>  		/* " f7c0c00 [ahead 58, behind 197] vcs-svn: drop obj_pool.h" */
>  		add_verbose_info(&out, item, verbose, abbrev);
> -	printf("%s\n", out.buf);
> +	print_cell(&output, colopts, out.buf);
>  	strbuf_release(&name);
>  	strbuf_release(&out);
>  }

Hmm, disabling column output when verbose is in effect without telling the user what we are doing needs to be fixed, but because of that, at least this codepath won't try to stuff potentially long strings in a columnar form.

I am not sure about the utility of columnar output for "git branch" in the short form. You no longer can just scan the leftmost column to scan for '*' to see the current branch.