Re: [PATCH v4 08/13] column: add column.ui for default column output settings
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 3, 2012, 23:04 UTC
- Message-ID
- <7v62fnmsc5.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1328276078-27955-9-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
Show 9 quoted lines
> diff --git a/column.h b/column.h
> index 1912cb0..afdafc4 100644
> --- a/column.h
> +++ b/column.h
> @@ -17,6 +17,8 @@ struct column_options {
> const char *nl;
> };
>
> +extern int git_colopts;For a global state variable, I'd prefer to see it spelled out, e.g. git_column_opts or even git_column_options. It's not like you would be referring to this variable from everywhere---you would use it only from fallback codepaths after parse_options() returns, or something, no?