Re: [PATCH v4 02/13] column: add API to print items in columns

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 3, 2012, 23:16 UTC
Message-ID: <7vsjirld82.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1328276078-27955-3-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

Show 20 quoted lines

> +#define MODE(mode) ((mode) & COL_MODE)
> + ...
> +void print_columns(const struct string_list *list, int mode,
> +		   struct column_options *opts)
> +{
> +	const char *indent = "", *nl = "\n";
> +	int padding = 1, width = term_columns();
> +
> +	if (!list->nr)
> +		return;
> +	if (opts) {
> +		if (opts->indent)
> +			indent = opts->indent;
> +		if (opts->nl)
> +			nl = opts->nl;
> +		if (opts->width)
> +			width = opts->width;
> +		padding = opts->padding;
> +	}
> +	if (width <= 1 || !(mode & COL_ENABLED)) {

Unless there is a compelling reason not to, make a flag word used as collection of bitfields an unsigned, i.e. not "int mode".