Re: [PATCH 2/2] ctype: implement islower/isupper macro
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 10, 2012, 02:17 UTC
- Message-ID
- <7vwr7vsa8j.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1328840011-19028-2-git-send-email-namhyung.kim@lge.com>
Namhyung Kim <namhyung.kim@lge.com> writes:
> The git-compat-util.h provides various ctype macros but lacks those two > (along with others). Add them.
Isn't that because we do not use them ourselves? Uses in compat/ do not count, and judging from the way it is used in compat/fnmatch/fnmatch.c, the implementation of sane_iscase() might be overly protective.
What problem are you trying to solve?