git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] ctype: implement islower/isupper macro

From
김남형 <namhyung.kim@lge.com>
Date
Feb 10, 2012, 02:32 UTC
Message-ID
<4F3481CD.5010303@lge.com>
In-Reply-To
<7vwr7vsa8j.fsf@alter.siamese.dyndns.org>
Hello,
2012-02-10 11:17 AM, Junio C Hamano wrote:
Show 11 quoted lines
> Namhyung Kim <namhyung.kim@lge.com> writes:
>
>> The git-compat-util.h provides various ctype macros but lacks those two
>> (along with others). Add them.
>
> Isn't that because we do not use them ourselves? Uses in compat/ do not
> count, and judging from the way it is used in compat/fnmatch/fnmatch.c,
> the implementation of sane_iscase() might be overly protective.
>
> What problem are you trying to solve?
>

There's no problem. In fact, these patches come from perf as it uses a copy of git code in this part. So I didn't check it's really needed for git too, but just hoped it'd be helpful someday. If you don't think it's worth applying I'm fine with dropping it.

Thanks, Namhyung

Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 6 in “ctype.c only wants git-compat-util.h”
  1. 1/2 ctype.c only wants git-compat-util.hNamhyung Kim, Feb 10, 2012
  2. 2/2 ctype: implement islower/isupper macroNamhyung Kim, Feb 10, 2012
  3. Junio C HamanoFeb 10, 2012
  4. 김남형Feb 10, 2012
  5. Junio C HamanoFeb 10, 2012
  6. Namhyung KimFeb 10, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.