Re: [PATCH 2/2] ctype: implement islower/isupper macro

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 10, 2012, 04:03 UTC
Message-ID: <7vliobs5bh.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4F3481CD.5010303@lge.com>

김남형 <namhyung.kim@lge.com> writes:

Show 14 quoted lines

> 2012-02-10 11:17 AM, Junio C Hamano wrote:
>> Namhyung Kim <namhyung.kim@lge.com> writes:
>>
>>> The git-compat-util.h provides various ctype macros but lacks those two
>>> (along with others). Add them.
>>
>> Isn't that because we do not use them ourselves? Uses in compat/ do not
>> count, and judging from the way it is used in compat/fnmatch/fnmatch.c,
>> the implementation of sane_iscase() might be overly protective.
>>
>> What problem are you trying to solve?
>
> There's no problem. In fact, these patches come from perf as it uses a
> copy of git code in this part.

Kim-ssi, the above is something I would have like to see in your first message.

> If you don't
> think it's worth applying I'm fine with dropping it.

I never said these patches are worthless.

I just was wondering what the motivation behind them were. If you are involved in maintaining Perf, and if it wants to keep its own forked copy as close as ours, that is a good enough justification, as long as the additions we do not use ourselves is still reasonably done.