Re: [PATCH] tests: turn on test-lint-shell-syntax by default

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 5, 2013, 21:56 UTC
Message-ID: <7vwqumqvav.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7v4nhqsctb.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 8 quoted lines

> Torsten Bögershausen <tboegi@web.de> writes:
>
>> Thanks for the detailed suggestion.
>> Instead of using a file for putting out non portable syntax,
>> can we can use a similar logic as test_failure ?
>
> Your test_bad_syntax_ function can be called from a subshell, and
> its "exit 1" will not exit, no?

What is more important is that the increment to $test_bad_syntax done in that function will not be propagated up to the main process that runs the test framework.

Of course, that is why I mentioned communicating using the filesystem.