Re: [PATCH] tests: turn on test-lint-shell-syntax by default

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 13, 2013, 17:32 UTC
Message-ID: <20130113173207.GC5973@elie.Belkin>
In-Reply-To: <50F28BB5.9080607@web.de>

Hi,

Torsten Bögershausen wrote:

> -	/^\s*[^#]\s*which\s/ and err 'which is not portable (please use type)';
> +	/^\s*[^#]\s*which\s+[-a-zA-Z0-9]+$/ and err 'which is not portable (please use type)';

Hmm. Neither the old version nor the new one matches what seem to be typical uses of 'which', based on a quick code search:

	if which sl >/dev/null 2>&1
	then
		sl -l
		...
	fi

or

	if test -x "$(which sl 2>/dev/null)"
	then
		sl -l
		...
	fi