Re: [PATCH] tests: turn on test-lint-shell-syntax by default

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 15, 2013, 20:38 UTC
Message-ID: <7vk3re2ncb.fsf@alter.siamese.dyndns.org>
In-Reply-To: <50F5B83E.9060800@web.de>

Torsten Bögershausen <tboegi@web.de> writes:

Show 15 quoted lines

> What do we think about something like this for fishing for which:
>
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -644,6 +644,10 @@ yes () {
>                 :
>         done
>  }
> +which () {
> +       echo >&2 "which is not portable (please use type)"
> +       exit 1
> +}
>
>
> This will happen in runtime, which might be good enough ?

	if (
		which frotz &&
                test $(frobonitz --version" -le 2.0
	   )
        then
		test_set_prereq FROTZ_FROBONITZ
	else
		echo >&2 "suitable Frotz/Frobonitz combo not available;"
                echo >&2 "some tests may be skipped"
	fi

I somehow think this is a lost cause.