Re: [PATCH] test-bzr: Do not use unportable sed "\+"

From: Junio C Hamano <gitster@pobox.com>
Date: May 11, 2013, 18:52 UTC
Message-ID: <7vwqr5wdqm.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201305111525.53130.tboegi@web.de>

Torsten Bögershausen <tboegi@web.de> writes:

Show 5 quoted lines

> Using sed -e '/[0-9]\+//' to find "one ore more" digits
> is not portable.
> Use the Basic Regular Expression '/[0-9][0-9]*//' instead
>
> Signed-off-by: Torsten Bögershausen <tboegi@web.de>

Thanks. Is there another one in t/t5551-http-fetch.sh that checks the tags?

Show 17 quoted lines

> ---
>  contrib/remote-helpers/test-bzr.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/remote-helpers/test-bzr.sh b/contrib/remote-helpers/test-bzr.sh
> index d9c32f4..5dfa070 100755
> --- a/contrib/remote-helpers/test-bzr.sh
> +++ b/contrib/remote-helpers/test-bzr.sh
> @@ -328,7 +328,7 @@ test_expect_success 'strip' '
>  
>    echo four >> content &&
>    bzr commit -m four &&
> -  bzr log --line | sed -e "s/^[0-9]\+: //" > ../expected
> +  bzr log --line | sed -e "s/^[0-9][0-9]*: //" > ../expected
>    ) &&
>  
>    (cd gitrepo &&