Re: [PATCH] test-bzr: Do not use unportable sed "\+"
- From
Torsten Bögershausen <tboegi@web.de>
- Date
- May 11, 2013, 20:35 UTC
- Message-ID
- <518EAB7C.3010508@web.de>
- In-Reply-To
- <7v8v3lwa5p.fsf@alter.siamese.dyndns.org>
On 11.05.13 22:09, Junio C Hamano wrote:
Show 8 quoted lines
> Torsten Bögershausen <tboegi@web.de> writes: > >> I did, >> the interesting thing is that the test passes with and without your patch. >> (After enabling GIT_TEST_LONG and GIT_TEST_HTTPD in both cases) > > Strange. Do you see differences between the produced packed-refs > file?
The original version seems to look like this: :1 666527db455708922859283c673094002092910b :2 1e2acf73c6db881cfb1d56d67662e3d9260be2cf [snip]
The "fixed POSIX version" follows that style: 666527db455708922859283c673094002092910b refs/tags/blablablablablablablablablablablablablablablablablablablablablablablablablablablablablabla-1 1e2acf73c6db881cfb1d56d67662e3d9260be2cf refs/tags/blablablablablablablablablablablablablablablablablablablablablablablablablablablablablabla-2 [snip]
(Just to verify the changes:)
diff --git a/t/t5551-http-fetch.sh b/t/t5551-http-fetch.sh index b23efbb..68965f0 100755 --- a/t/t5551-http-fetch.sh +++ b/t/t5551-http-fetch.sh @@ -210,8 +210,11 @@ test_expect_success EXPENSIVE 'create 50,000 tags in the repo' ' # now assign tags to all the dangling commits we created above tag=$("$PERL_PATH" -e "print \"bla\" x 30") && sed -e "s/^:\(.\+\) \(.\+\)$/\2 refs\/tags\/$tag-\1/" <marks >>packed-refs + sed -e "s|^:\([^ ]*\) \(.*\)$|\2 refs/tags/$tag-\1|" <marks >packed-refs.junio + sed -e "s/^:\(.\+\) \(.\+\)$/\2 refs\/tags\/$tag-\1/" <marks >packed-refs.orig ) ' + exit 0