Re: [PATCH] t5551: do not use unportable sed '\+'

From: Torsten Bögershausen <tboegi@web.de>
Date: May 13, 2013, 18:24 UTC
Message-ID: <51912FEC.6020909@web.de>
In-Reply-To: <7vtxm6n8pj.fsf@alter.siamese.dyndns.org>

On 2013-05-13 18.30, Junio C Hamano wrote:

Show 13 quoted lines

> Torsten Bögershausen <tboegi@web.de> writes:
> 
>> On 2013-05-13 00.50, Junio C Hamano wrote:
>>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>>> ---
>>>  t/t5551-http-fetch.sh | 8 ++++++--
>>>  1 file changed, 6 insertions(+), 2 deletions(-)
>>>
>> Thanks, works like a charm, tested on Mac OS.
>> /torsten
> 
> Thanks; I take it that you reverted the "sed fix" part and saw the
> updated "clone" check fail with the platform "sed"?

In my first test with the fix the test case passed. Then the sed expression was only manipulated to verify that the TC failes. And now I took even the original expression and have verfied it is failing.

The short version: Yes