git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: "make test" fails with current HEAD

From
Junio C Hamano <junkio@cox.net>
Date
Nov 18, 2005, 19:13 UTC
Message-ID
<7vveypkbwa.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<7vwtj5lvvc.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> writes:
Show 6 quoted lines
> Linus Torvalds <torvalds@osdl.org> writes:
>
>> Umm.. Why not just say "if the line after the 'diff' line doesn't start 
>> with '@@ ', then it's a binary diff"?
>
> Thanks, that makes sense.

Maybe not; parse_single_patch would have eaten '@@ -' lines so in practice that amounts to not checking anything at all.

Which is not a bad idea, though... That means we would treat all empty patches as binary diffs, which is certainly simple, but is it safe enough?

Previous: Junio C HamanoNext: Junio C Hamano
Message 17 of 20 in “"make test" fails with current HEAD”
  1. Matthias UrlichsNov 17, 2005
  2. Johannes SchindelinNov 17, 2005
  3. Matthias UrlichsNov 17, 2005
  4. A Large Angry SCMNov 18, 2005
  5. Johannes SchindelinNov 18, 2005
  6. Matthias UrlichsNov 18, 2005
  7. Junio C HamanoNov 18, 2005
  8. Matthias UrlichsNov 18, 2005
  9. Junio C HamanoNov 18, 2005
  10. Matthias UrlichsNov 18, 2005
  11. Johannes SchindelinNov 18, 2005
  12. Matthias UrlichsNov 18, 2005
  13. Johannes SchindelinNov 18, 2005
  14. Matthias UrlichsNov 18, 2005
  15. Linus TorvaldsNov 18, 2005
  16. Junio C HamanoNov 18, 2005
  17. Junio C HamanoNov 18, 2005
  18. Junio C HamanoNov 18, 2005
  19. John BenesNov 18, 2005
  20. Do not show .exe in git command list.Junio C Hamano, Nov 18, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.