Re: "make test" fails with current HEAD

From: Matthias Urlichs <smurf@smurf.noris.de>
Date: Nov 18, 2005, 10:54 UTC
Message-ID: <20051118105415.GN31613@kiste.smurf.noris.de>
In-Reply-To: <Pine.LNX.4.63.0511181134080.8037@wbgn013.biozentrum.uni-wuerzburg.de>

Hi,

Johannes Schindelin:

Show 10 quoted lines

> From my diff man page:
> 
> -- snip --
> DIAGNOSTICS
>        An  exit status of 0 means no differences were found, 1 means some 
>        differences were found, and 2 means trouble.
> -- snap --
> 
> The exit value 2 is ambiguous for at least one version of GNU diff.
>

AFAIK, We have
0 - no difference
1 - produced a reasonable diff
1 - produced a bad diff because binary stuff starts
    after 4096-or-whatever bytes and diff didn't notice
2 - didn't produce a diff -- binary files differ
2 - something else broke

Right now we simply don't consider the second -2- case, because we just successfully wrote the two files in question; there's not *that* much that can fail after that. The second -1- case is sufficiently rare too.

So I still think a "Just write a 'Binary files FOO and BAR differ' line if the exit status is 2" rule would at least fix the current bug with diff 2.8.7.

-- 
Matthias Urlichs   |   {M:U} IT Design @ m-u-it.de   |  smurf@smurf.noris.de
Disclaimer: The quote was selected randomly. Really. | http://smurf.noris.de
 - -
<Knghtbrd> xtifr - beware of james when he's off his medication  =3D>