From: Junio C Hamano <junkio@cox.net>
Date: Fri, 18 Nov 2005 19:13:09 GMT
Subject: Re: "make test" fails with current HEAD
Message-ID: <7vveypkbwa.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <7vwtj5lvvc.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> writes:

> Linus Torvalds <torvalds@osdl.org> writes:
>
>> Umm.. Why not just say "if the line after the 'diff' line doesn't start 
>> with '@@ ', then it's a binary diff"?
>
> Thanks, that makes sense.

Maybe not; parse_single_patch would have eaten '@@ -' lines so
in practice that amounts to not checking anything at all.

Which is not a bad idea, though...  That means we would treat
all empty patches as binary diffs, which is certainly simple,
but is it safe enough?