Re: git send-email woes

From: Junio C Hamano <junkio@cox.net>
Date: Sep 26, 2006, 04:11 UTC
Message-ID: <7vvenbuv0t.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060925215127.GA3965@uranus.ravnborg.org>

Sam Ravnborg <sam@ravnborg.org> writes:

Show 15 quoted lines

>> @@ -431,6 +431,11 @@ sub send_message
>>  	    $gitversion =~ s/^.* //;
>>  	}
>>  
>> +	my ($author_name) = ($from =~ /^(.*?)\s+</);
>> +	if ($author_name =~ /\./ && $author_name !~ /^".*"$/) {
>> +		my ($name, $addr) = ($from =~ /^(.*?)(\s+<.*)/);
>> +		$from = "\"$name\"$addr";
>> +	}
>>  	my $header = "From: $from
>>  To: $to
>>  Cc: $cc
>> 
> I would assume we had to do the same for all mail addresses?
> In this case also for $to and $cc and $reply_to.

I do not think so, although I admit I only had a cursory look at the code. In this part of the code, $to and $cc are coming from return value of unique_email_list sub, which cleanses each address with extract_valid_address sub. This sub does:

	A U Thor <foo@bar.baz> => foo@bar.baz

In other words, I think it is only "$from" that needs it.

I think $to and $cc should not strip out the human-readable name, but in this case it saved us extra trouble. Sigh...