git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git send-email woes

From
Sam Ravnborg <sam@ravnborg.org>
Date
Sep 25, 2006, 18:32 UTC
Message-ID
<20060925183221.GE2490@uranus.ravnborg.org>
In-Reply-To
<20060924224316.GA28051@uranus.ravnborg.org>
On Mon, Sep 25, 2006 at 12:43:16AM +0200, Sam Ravnborg wrote:
Show 21 quoted lines
> I stumbled on two issues with git-send-email today.
> First of I forgot to tell where to find the patch files to send.
> But git-send-email only complained _after_ I had given all
> the information manually.
> It would have been niver to check that all mandatory arguments
> was present before being interactive.
> 
> The second issue are best explained quoting a mail from Matti Arnio:
> > > The GIT is at times producing emails that are not
> > > utterly strictly speaking kosher RFC-(2)822 format.
> > >
> > > It might be a surprise to you that unquoted dots in
> > > people's names cause syntax scanner indigestion,
> > > because said character has very special meaning in
> > > RFC-822 syntax.  All would be fine if
> > >     Example J.P. Example <example@example.net>
> > > had couple quotes:
> > >     "Example J.P. Example" <example@example.net>
> 
> What I could see was that git-send-email takes mail address
> verbatim from "Signed-off-by:" lines and use it.

The patches in quistion did not have a "Signed-off-by: tag so that mail address has been from the author instead. And this mail address was still invalid as per RFC2822.

Show 6 quoted lines
> Would it be possible to always quote it except when quoted
> or to do a more intelligent RFC2822 check?
> 
> That would keep suprises lower.
> 
> I'm not good a perlish so I have not attempted fixing it myself...
	Sam
Previous: Sam RavnborgNext: Junio C Hamano
Message 2 of 6 in “git send-email woes”
  1. Sam RavnborgSep 24, 2006
  2. Sam RavnborgSep 25, 2006
  3. Junio C HamanoSep 25, 2006
  4. David MillerSep 25, 2006
  5. Sam RavnborgSep 25, 2006
  6. Junio C HamanoSep 26, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.