Re: git send-email woes
- From
Junio C Hamano <junkio@cox.net>
- Date
- Sep 25, 2006, 19:58 UTC
- Message-ID
- <7v7izrzpk2.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <20060925183221.GE2490@uranus.ravnborg.org>
Sam Ravnborg <sam@ravnborg.org> writes:
> The patches in quistion did not have a "Signed-off-by: tag so > that mail address has been from the author instead. > And this mail address was still invalid as per RFC2822.
I do not think it takes Signed-off-by: as author in any case (and I do not think it should -- if it did so it is a bug).
Maybe something like this?
diff --git a/git-send-email.perl b/git-send-email.perl index 746c525..b4a34f4 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -431,6 +431,11 @@ sub send_message $gitversion =~ s/^.* //; } + my ($author_name) = ($from =~ /^(.*?)\s+</); + if ($author_name =~ /\./ && $author_name !~ /^".*"$/) { + my ($name, $addr) = ($from =~ /^(.*?)(\s+<.*)/); + $from = "\"$name\"$addr"; + } my $header = "From: $from To: $to Cc: $cc