git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [fixed PATCH] git-filter-branch.sh: Fix broken setting of GIT_DIR

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 11, 2007, 20:10 UTC
Message-ID
<7vveblltmw.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<46BDB0E7.3020506@midwinter.com>
Steven Grimm <koreth@midwinter.com> writes:
Show 9 quoted lines
> David Kastrup wrote:
>> Actually, wouldn't by far the most straightforward thing be if
>> git-rev-parse --git-dir always returned an absolute path (even when
>> being passed a relative path in GIT_DIR)?
>>
>
> That might also help get rid of an annoying failure mode where some
> git commands (the shell script ones) fail if you cd into a git
> repository via a symlink, while others (the builtins) work just fine.

It might be the easiest workaround for this issue to unset PWD in git-sh-setup.sh (and git-clone.sh) where we unset CDPATH. Anybody wants to try to come up with additional test scripts to expose the problem and a patch to these two files?

Previous: Steven Grimm
Message 15 of 15 in “git-filter-branch.sh: Fix broken setting of GIT_DIR”
  1. git-filter-branch.sh: Fix broken setting of GIT_DIRDavid Kastrup, Aug 10, 2007
  2. git-filter-branch.sh: Fix broken setting of GIT_DIRDavid Kastrup, Aug 10, 2007
  3. Junio C HamanoAug 11, 2007
  4. David KastrupAug 11, 2007
  5. David KastrupAug 11, 2007
  6. David KastrupAug 11, 2007
  7. Junio C HamanoAug 11, 2007
  8. David KastrupAug 11, 2007
  9. Add a test for git-commit being confused by relative GIT_DIRDavid Kastrup, Aug 11, 2007
  10. Junio C HamanoAug 12, 2007
  11. David KastrupAug 12, 2007
  12. Junio C HamanoAug 12, 2007
  13. David KastrupAug 12, 2007
  14. Steven GrimmAug 11, 2007
  15. Junio C HamanoAug 11, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.