Re: [PATCH] Add a test for git-commit being confused by relative GIT_DIR

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 12, 2007, 01:55 UTC
Message-ID: <7vvebljz31.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <85tzr5spaj.fsf@lola.goethe.zz>

David Kastrup <dak@gnu.org> writes:

Show 8 quoted lines

> +test_expect_success 'Setting up post-commit hook' '
> +mkdir -p .git/hooks &&
> +cat <<EOF >.git/hooks/post-commit &&
> +#!/bin/sh
> +touch $(pwd)/output
> +echo "Post commit hook was called."
> +EOF
> +chmod +x .git/hooks/post-commit'

We have avoided to use here text inside test_expect_success, as there have been reports that some otherwise reasonably usable shells do not grok it. Although I prefer to do everything, including the set-up part, inside test_expect_success, please move this code outside.

Also I do not think you would want to say touch $(pwd)/output there inside the here text that begins with <<EOF not <<\EOF.