Re: [fixed PATCH] git-filter-branch.sh: Fix broken setting of GIT_DIR

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 11, 2007, 10:06 UTC
Message-ID: <7vk5s2mllf.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <864pj74ay9.fsf@lola.quinscape.zz>

David Kastrup <dak@gnu.org> writes:

> If filter-branch is entered with an unset GIT_DIR, things are rather
> fragile.  The GIT_DIR variable setting then points to something like
> $(pwd)/../.. which is neither guaranteed to be a git directory

I think this comment refers to this part, ...

Show 7 quoted lines

> -case "$GIT_DIR" in
> -/*)
> -	;;
> -*)
> -	GIT_DIR="$(pwd)/../../$GIT_DIR"
> -	;;
> -esac

... however, at the beginning of the script, it dot-includes git-sh-setup, which sets (but not export) GIT_DIR for the rest of the script to use (see the last if..then..else).

If you got an unset GIT_DIR when you reached that case statement you are removing here, I suspect that there is something else going on, but I do not see what it is...

Puzzled...