Re: [PATCH 2/5] git-submodule: New subcommand 'summary' (2) - hard work

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 12, 2008, 19:25 UTC
Message-ID: <7vve5ysv72.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <46dff0320801120312i7b22f13vb9fe2394b1f687a9@mail.gmail.com>

"Ping Yin" <pkufranky@gmail.com> writes:

Show 6 quoted lines

>> +                       echo "* $name $sha1_src...$sha1_dst:"
>
> If it's a type change (head submodule but index blob, or the the
> reverse), $sha1_dst or $sha1_src will be the sha1 of the blob. It's
> inapprociate to be shown as if it's a commit in the submodule. May
> 00000000 should be shown instead of the blob sha1?

I do not think that adds much value. When A or B is a non-commit, you know that A...B notation does not apply, and because it is probably a rare situation you would want to make it even more clearer to the reader by using a different notation. Like

    echo "* $name have changed from submodule $sha1_src to blob $sha1_dst!!".

perhaps in red bold letter in larger font ;-)