Re: [PATCH 3/5] git-submodule: New subcommand 'summary' (3) - limit summary size

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 12, 2008, 08:36 UTC
Message-ID: <7vabnbv3sb.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <bce0ee9fde688c27fc788fab91a571184918da67.1200122041.git.pkufranky@gmail.com>

Ping Yin <pkufranky@gmail.com> writes:

Show 5 quoted lines

> @@ -265,6 +267,10 @@ set_name_rev () {
>  #
>  modules_summary()
>  {
> +	summary_limit=${summary_limit:-1000000}

Why a million?

> +	summary_limit=$((summary_limit<0?1000000:summary_limit))

This is doubly bashism. Variables must be referenced with $, and $(( conditional ? iftrue : iffalse )) is not POSIX.