git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/5] git-submodule: New subcommand 'summary' (2) - hard work

From
Ping Yin <pkufranky@gmail.com>
Date
Jan 13, 2008, 06:28 UTC
Message-ID
<46dff0320801122228r4261786eo2f23258e79f2e346@mail.gmail.com>
In-Reply-To
<7vve5ysv72.fsf@gitster.siamese.dyndns.org>
On Jan 13, 2008 3:25 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 19 quoted lines
> "Ping Yin" <pkufranky@gmail.com> writes:
>
> >> +                       echo "* $name $sha1_src...$sha1_dst:"
> >
> > If it's a type change (head submodule but index blob, or the the
> > reverse), $sha1_dst or $sha1_src will be the sha1 of the blob. It's
> > inapprociate to be shown as if it's a commit in the submodule. May
> > 00000000 should be shown instead of the blob sha1?
>
> I do not think that adds much value.  When A or B is a
> non-commit, you know that A...B notation does not apply, and
> because it is probably a rare situation you would want to make
> it even more clearer to the reader by using a different
> notation.  Like
>
>     echo "* $name have changed from submodule $sha1_src to blob $sha1_dst!!".
>
> perhaps in red bold letter in larger font ;-)
>
OK, i will think over.
-- 
Ping Yin
Previous: Junio C HamanoNext: Junio C Hamano
Message 17 of 19 in “submodule summary support”
  1. 0/5 submodule summary supportPing Yin, Jan 12, 2008
  2. 1/5 git-submodule: New subcommand 'summary' (1) - code frameworkPing Yin, Jan 12, 2008
  3. 2/5 git-submodule: New subcommand 'summary' (2) - hard workPing Yin, Jan 12, 2008
  4. 3/5 git-submodule: New subcommand 'summary' (3) - limit summary sizePing Yin, Jan 12, 2008
  5. 4/5 git-status: submodule summary supportPing Yin, Jan 12, 2008
  6. 5/5 git-status: configurable submodule summary sizePing Yin, Jan 12, 2008
  7. Junio C HamanoJan 12, 2008
  8. Ping YinJan 12, 2008
  9. Junio C HamanoJan 12, 2008
  10. Ping YinJan 13, 2008
  11. Junio C HamanoJan 12, 2008
  12. Ping YinJan 12, 2008
  13. Ping YinJan 12, 2008
  14. Junio C HamanoJan 12, 2008
  15. Ping YinJan 12, 2008
  16. Junio C HamanoJan 12, 2008
  17. Ping YinJan 13, 2008
  18. Junio C HamanoJan 12, 2008
  19. Ping YinJan 12, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.