Re: [PATCH] treat any file with NUL as binary
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 16, 2008, 01:16 UTC
- Message-ID
- <7vve5ubmdm.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20080116011321.GD13984@dpotapov.dyndns.org>
Dmitry Potapov <dpotapov@gmail.com> writes:
> Then it seems to me, Linus sounded more in favor of that change than > against it. His main argument was against 'diff' heuristic, which he > felt was not strict enough for CRLF translation: "It's *much* better > to miss some CRLF translation than to do too much of it."
Yeah, you found the right one, and I agreed with the argument back then, and I agree with it now. I think NUL heuristics is a good one and obviously it makes it tighter than what diff uses, which should be what we are aiming for in this thread.