Re: [PATCH] treat any file with NUL as binary
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 15, 2008, 23:11 UTC
- Message-ID
- <7vsl0yd6r8.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <1200407309-10992-1-git-send-email-dpotapov@gmail.com>
Dmitry Potapov <dpotapov@gmail.com> writes:
> So, please, consider it for inclusion as a bug fix.
Somebody has to go back to the "git log" output and the list archive to see if you two did not forget other ramifications, because I vaguely recall this 1% thing was done for a reason and Linus had a very good argument (at least back then the argument sounded very good to me) supporting the deliberate difference between the two "binary" heuristics.
If I did not have that vague recollection and all I had to judge the proposed change were the issue in this thread, I'd probably agree this is a good change, though.