git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] treat any file with NUL as binary

From
Dmitry Potapov <dpotapov@gmail.com>
Date
Jan 16, 2008, 01:13 UTC
Message-ID
<20080116011321.GD13984@dpotapov.dyndns.org>
In-Reply-To
<7vsl0yd6r8.fsf@gitster.siamese.dyndns.org>
On Tue, Jan 15, 2008 at 03:11:07PM -0800, Junio C Hamano wrote:
Show 10 quoted lines
> Dmitry Potapov <dpotapov@gmail.com> writes:
> 
> > So, please, consider it for inclusion as a bug fix.
> 
> Somebody has to go back to the "git log" output and the list
> archive to see if you two did not forget other ramifications,
> because I vaguely recall this 1% thing was done for a reason and
> Linus had a very good argument (at least back then the argument
> sounded very good to me) supporting the deliberate difference
> between the two "binary" heuristics.

First of all, my patch does not make them being the same, it just makes one being stricter than the other, and I explained why it is the tight thing to do.

Second, it is difficult for me to find to what particular words of Linus *you* refer to. However, if it is something like this post:

http://article.gmane.org/gmane.comp.version-control.git/39618

Then it seems to me, Linus sounded more in favor of that change than against it. His main argument was against 'diff' heuristic, which he felt was not strict enough for CRLF translation: "It's *much* better to miss some CRLF translation than to do too much of it."

Dmitry
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 7 in “treat any file with NUL as binary”
  1. treat any file with NUL as binaryDmitry Potapov, Jan 15, 2008
  2. Steffen ProhaskaJan 15, 2008
  3. Junio C HamanoJan 15, 2008
  4. Dmitry PotapovJan 16, 2008
  5. Junio C HamanoJan 16, 2008
  6. Junio C HamanoJan 16, 2008
  7. treat any file with NUL as binaryDmitry Potapov, Jan 16, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.