git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] builtin-push: add --delete as syntactic sugar for :foo

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 30, 2009, 19:49 UTC
Message-ID
<7vvdfoz1hi.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20091230105244.67f5969e@perceptron>
Jan Krüger <jk@jk.gs> writes:
Show 12 quoted lines
> Refspecs without a source side have been reported as confusing by many.
> As an alternative, this adds support for commands like:
>
>     git push origin --delete somebranch
>     git push origin --delete tag sometag
>
> Specifically, --delete will prepend a colon to all colon-less refspecs
> given on the command line, and will refuse to accept refspecs with
> colons to prevent undue confusion.
>
> Signed-off-by: Jan Krüger <jk@jk.gs>
> ---

Thanks. From a cursory read, the patch looks good. We would however want to have a test that has test_must_fail to protect the error codepath from getting broken in the future.

Previous: Sverre RabbelierNext: Jan Krüger
Message 10 of 11 in “builtin-push: add --delete as syntactic sugar for :foo”
  1. builtin-push: add --delete as syntactic sugar for :fooJan Krüger, Nov 9, 2009
  2. Junio C HamanoNov 9, 2009
  3. Junio C HamanoNov 9, 2009
  4. Sverre RabbelierNov 9, 2009
  5. builtin-push: add --delete as syntactic sugar for :fooJan Krüger, Nov 9, 2009
  6. Nanako ShiraishiDec 29, 2009
  7. Junio C HamanoDec 29, 2009
  8. builtin-push: add --delete as syntactic sugar for :fooJan Krüger, Dec 30, 2009
  9. Sverre RabbelierDec 30, 2009
  10. Junio C HamanoDec 30, 2009
  11. builtin-push: add --delete as syntactic sugar for :fooJan Krüger, Dec 30, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.