From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 30 Dec 2009 19:49:13 GMT
Subject: Re: [PATCH v3] builtin-push: add --delete as syntactic sugar for :foo
Message-ID: <7vvdfoz1hi.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20091230105244.67f5969e@perceptron>

Jan Krüger <jk@jk.gs> writes:

> Refspecs without a source side have been reported as confusing by many.
> As an alternative, this adds support for commands like:
>
>     git push origin --delete somebranch
>     git push origin --delete tag sometag
>
> Specifically, --delete will prepend a colon to all colon-less refspecs
> given on the command line, and will refuse to accept refspecs with
> colons to prevent undue confusion.
>
> Signed-off-by: Jan Krüger <jk@jk.gs>
> ---

Thanks.  From a cursory read, the patch looks good.  We would however want
to have a test that has test_must_fail to protect the error codepath from
getting broken in the future.